On Tue, Nov 19, 2024 at 12:59:23AM +0000, Wei Yang wrote: > > Thanks for your explanation. This looks neat. > > So it hide the reason of deferred merge from user, we would think both two > cases would lead to a deferred merge. This is what we want to have, right? > > > > >In your proposed code I see: > > > >- prepare for mmap > >- try to merge > >- if merge failed, create new > > - if merge failed, created new, and we required a deferred merge, do a deferred merge > > Maybe here is > > - maybe do a deferred merge > > >- mmap complete, do 'after mmap' tasks. > > > >It's about humans reading this and being able to understand what is going > >on. > > > -- > Wei Yang > Help you, Help me > With respect Wei, I feel like I've already addressed all this, and I don't want to go around in circles! :)