On Mon, Nov 18, 2024 at 3:44 PM Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > > On Mon, Nov 18, 2024 at 03:40:57PM -0500, Pasha Tatashin wrote: > > > You're putting something in an mm/ C-file and the header in fs.h? Eh? > > > > This is done so we do not have to include struct path into vma.h. fs.h > > already has some vma functions like: vma_is_dax() and vma_is_fsdax(). > > Yes, but DAX is a monumental layering violation, not something to be > emulated. Fair enough, but I do not like adding "struct path" dependency to vma.h, is there a better place to put it? Pasha