Re: [PATCH -next] mm/ksm: Add missing IS_ERR_OR_NULL check for stable_tree_search()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 15.11.24 16:41, Matthew Wilcox wrote:
On Fri, Nov 15, 2024 at 11:44:10AM +0100, David Hildenbrand wrote:
On 24.10.24 05:23, Gaosheng Cui wrote:
The stable_tree_search() maybe return -EBUSY if the stable node's page
is being migrated or nullptr, we need to check kfolio with
IS_ERR_OR_NULL() before dereference it.

Argh.  I doidn't notice this when it came through.  Andrew already
folded it in, but it's utter garbage.  We don't dereference folio.
NAK.

Ah, &kfolio->page indeed doesn't de-reference. I was blindly assuming someone actually ran into an issue here.

Thanks for double-checking ...

--
Cheers,

David / dhildenb





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux