Hello.
On čtvrtek 14. listopadu 2024 20:02:04, středoevropský standardní čas SeongJae Park wrote:
> On Thu, 14 Nov 2024 11:01:40 +0100 Oleksandr Natalenko <oleksandr@xxxxxxxxxxxxxx> wrote:
>
> > At one point I needed mm tools for debugging but couldn't compile them due to the
> > following error:
> >
> > gcc -Wall -Wextra -I../lib/ -pthread -o page-types page-types.c ../lib/api/libapi.a -pthread
> > page-types.c: In function \u2018show_page\u2019:
> > page-types.c:423:49: error: expected \u2018;\u2019 before \u2018if\u2019
> > 423 | printf("@%" PRIu64 "\t", cgroup)
> > | ^
> > | ;
> > 424 | if (opt_list_mapcnt)
> > | ~~
> > page-types.c:416:65: warning: unused parameter \u2018mapcnt\u2019 [-Wunused-parameter]
> > 416 | uint64_t flags, uint64_t cgroup, uint64_t mapcnt)
> > | ~~~~~~~~~^~~~~~
> > make: *** [Makefile:23: page-types] Error 1
> >
> > Trailing ; was forgotten, so add it.
> >
> > Fixes: ece5897e5a10 ("tools/mm: -Werror fixes in page-types/slabinfo")
> > Signed-off-by: Oleksandr Natalenko <oleksandr@xxxxxxxxxxxxxx>
> > ---
> > tools/mm/page-types.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/mm/page-types.c b/tools/mm/page-types.c
> > index 6eb17cc1a06c5..bcac7ebfb51fd 100644
> > --- a/tools/mm/page-types.c
> > +++ b/tools/mm/page-types.c
> > @@ -420,7 +420,7 @@ static void show_page(unsigned long voffset, unsigned long offset,
> > if (opt_file)
> > printf("%lx\t", voffset);
> > if (opt_list_cgroup)
> > - printf("@%" PRIu64 "\t", cgroup)
> > + printf("@%" PRIu64 "\t", cgroup);
> > if (opt_list_mapcnt)
> > printf("%" PRIu64 "\t", mapcnt);
> >
>
> Just FYI, a very similar patch has posted a few days ago:
> https://lore.kernel.org/20241112171655.1662670-1-motiejus@xxxxxxxxxx
OK, if the other one is taken, consider adding my Acked-by: then.
Thank you.
--
Oleksandr Natalenko, MSEAttachment:
signature.asc
Description: This is a digitally signed message part.
