At one point I needed mm tools for debugging but couldn't compile them due to the
following error:
gcc -Wall -Wextra -I../lib/ -pthread -o page-types page-types.c ../lib/api/libapi.a -pthread
page-types.c: In function ‘show_page’:
page-types.c:423:49: error: expected ‘;’ before ‘if’
423 | printf("@%" PRIu64 "\t", cgroup)
| ^
| ;
424 | if (opt_list_mapcnt)
| ~~
page-types.c:416:65: warning: unused parameter ‘mapcnt’ [-Wunused-parameter]
416 | uint64_t flags, uint64_t cgroup, uint64_t mapcnt)
| ~~~~~~~~~^~~~~~
make: *** [Makefile:23: page-types] Error 1
Trailing ; was forgotten, so add it.
Fixes: ece5897e5a10 ("tools/mm: -Werror fixes in page-types/slabinfo")
Signed-off-by: Oleksandr Natalenko <oleksandr@xxxxxxxxxxxxxx>
---
tools/mm/page-types.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/mm/page-types.c b/tools/mm/page-types.c
index 6eb17cc1a06c5..bcac7ebfb51fd 100644
--- a/tools/mm/page-types.c
+++ b/tools/mm/page-types.c
@@ -420,7 +420,7 @@ static void show_page(unsigned long voffset, unsigned long offset,
if (opt_file)
printf("%lx\t", voffset);
if (opt_list_cgroup)
- printf("@%" PRIu64 "\t", cgroup)
+ printf("@%" PRIu64 "\t", cgroup);
if (opt_list_mapcnt)
printf("%" PRIu64 "\t", mapcnt);
--
2.47.0
