Re: C13 [01/14] slub: Add debugging to verify correct cache use on kmem_cache_free()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/24/2012 08:17 PM, Christoph Lameter wrote:
> Add additional debugging to check that the objects is actually from the cache
> the caller claims. Doing so currently trips up some other debugging code. It
> takes a lot to infer from that what was happening.
> 
> V2: Only warn once.
> 
> Signed-off-by: Christoph Lameter <cl@xxxxxxxxx>

I am fine with it.

Reviewed-by: Glauber Costa <glommer@xxxxxxxxxxxxx>
> ---
>  mm/slub.c |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/mm/slub.c b/mm/slub.c
> index c67bd0a..00f8557 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -2614,6 +2614,13 @@ void kmem_cache_free(struct kmem_cache *s, void *x)
>  
>  	page = virt_to_head_page(x);
>  
> +	if (kmem_cache_debug(s) && page->slab != s) {
> +		printk("kmem_cache_free: Wrong slab cache. %s but object"
> +			" is from  %s\n", page->slab->name, s->name);
> +		WARN_ON_ONCE(1);
> +		return;
> +	}
> +
>  	slab_free(s, page, x, _RET_IP_);
>  
>  	trace_kmem_cache_free(_RET_IP_, x);
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]