On Mon, 11 Nov 2024 at 12:19, Josef Bacik <josef@xxxxxxxxxxxxxx> wrote: > > - Linus had problems with this and rejected Jan's PR > (https://lore.kernel.org/linux-fsdevel/20240923110348.tbwihs42dxxltabc@quack3/), > so I'm respinning this series to address his concerns. Hopefully this is more > acceptable. I'm still rejecting this. I spent some time trying to avoid overhead in the really basic permission code the last couple of weeks, and I look at this and go "this is adding more overhead". It all seems to be completely broken too. Doing some permission check at open() time *aftert* the O_TRUNC has already truncated the file? No. That's just beyond stupid. That's just terminally broken sh*t. And that's just the stuff I noticed until I got so fed up that I stopped reading the patches. Linus
