On Thu, Nov 07, 2024 at 01:27:53PM -0500, Joshua Hahn wrote: > On Wed, Nov 6, 2024 at 6:50 PM Shakeel Butt <shakeel.butt@xxxxxxxxx> wrote: > > > > Please cleanup mem_cgroup_cancel_charge() and mem_cgroup_commit_charge() > > as well as there will be no users after this patch. > > > > Hi Shakeel, > > Thank you for your feedback. Unfortunately, it seems like even after this > patch removes the references from hugetlb.c, there are still some > references from other files. > > mem_cgroup_cancel_charge: > - memcontrol-v1.c~__mem_cgroup_clear_mc(void) __mem_cgroup_clear_mc() is gone. No more reference to mem_cgroup_cancel_charge after your patch. > > mem_cgroup_commit_charge: > - memcontrol.c~charge_memcg(struct folio *folio, struct mem_cgroup...) > > In fact, in my patch, I add an extra call to charge_memcg. I think for this > case, it makes sense to just extract out the functionality from > mem_cgroup_commit_charge (3 lines) and expand it out inside charge_memcg, > and get rid of mem_cgroup_commit_charge. Yup just inline mem_cgroup_commit_charge into charge_memcg and remove mem_cgroup_commit_charge.
