On Wed, 6 Nov 2024 17:21:14 +0800 Yafang Shao <laoar.shao@xxxxxxxxx> wrote: > When large folio support is enabled and read_ahead_kb is set to a smaller > value, ra->size (4MB) may exceed the maximum allowed size (e.g., 128KB). To > address this, we need to add a conditional check for such cases. However, > this alone is insufficient, as users might set read_ahead_kb to a larger, > non-hugepage-aligned value (e.g., 4MB + 128KB). In these instances, it is > essential to explicitly align ra->size with the hugepage size. How much performance improvement is this likely to offer our users? IOW, should we consider backporting it? (I bet anyone who comes across this will say "oh goody" and backport it anyway, so why not do this for them?)