On Wed, Nov 06, 2024 at 10:56:29AM +0800, Qi Zheng wrote: > > > On 2024/11/5 00:42, Lorenzo Stoakes wrote: > > On Sat, Nov 02, 2024 at 02:45:35AM +0100, Jann Horn wrote: > > > On Fri, Nov 1, 2024 at 7:50 PM Lorenzo Stoakes > > [...] > > > > > + > > > > +Page table locks > > > > +---------------- > > Many thanks to Lorenzo for documenting page table locks! This is really > needed. And at a glance, I agree with Jann's additions. Thanks! Will be respinning with all comments taken into account relatively soon. > > > > > > > (except last-level page tables: khugepaged already deletes those for > > > file mappings without using the mmap lock at all in > > > retract_page_tables(), and there is a pending series that will do the > > > same with page tables in other VMAs too, see > > > <https://lore.kernel.org/all/cover.1729157502.git.zhengqi.arch@xxxxxxxxxxxxx/>) > > Thanks to Jann for mentioning this series, I just updated it to v2 > recently: > > https://lore.kernel.org/lkml/cover.1730360798.git.zhengqi.arch@xxxxxxxxxxxxx/ Yeah I need to read through a little bit as I was unaware of these paths (mm is a big and sprawling subsystem more so than one might expect... :) Could you cc- me on any respin, as at least an interested observer? Thanks! > > > > > Ugh wut OK haha. Will look into this. > > Thanks! > :>)