On Fri, Aug 24, 2012 at 01:23:29PM +0200, Jim Meyering wrote: > In that case, what would you think of a patch to use strcpy instead? > > - strncpy(object->comm, current->comm, sizeof(object->comm)); > + strcpy(object->comm, current->comm); Another option would be to use strlcpy(). It's slightly neater than the strncpy() followed by a NUL assignment. > > Is there a preferred method of adding a static_assert-like statement? > I see compile_time_assert and a few similar macros, but I haven't > spotted anything that is used project-wide. BUILD_BUG_ON(). regards, dan carpenter -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>