On 11/5/24 12:47 AM, David Hildenbrand wrote:
On 05.11.24 04:29, John Hubbard wrote:
...
return ret;
}
+static long
+check_and_migrate_movable_pages_or_folios(struct pages_or_folios *pofs)
+{
+ LIST_HEAD(movable_folio_list);
+ unsigned long collected;
+
+ collected =
+ collect_longterm_unpinnable_folios(&movable_folio_list, pofs);
Nit: We're allowed to use more than 80 characters :)
Yes, I'm aware. Most of gup.c stays nicely within 80 cols, so it's nice
to keep that if not too awkward....
(I would prefer the old way it was split across more lines if we really want to split; this way here is less common)
OK, if I need to respin I'll apply this, to restore the old way. If
not, maybe Andrew can fix it up please?
diff --git a/mm/gup.c b/mm/gup.c
index 0f5121ad0b9f..0a22f7def83c 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -2435,8 +2435,8 @@ check_and_migrate_movable_pages_or_folios(struct pages_or_folios *pofs)
LIST_HEAD(movable_folio_list);
unsigned long collected;
- collected =
- collect_longterm_unpinnable_folios(&movable_folio_list, pofs);
+ collected = collect_longterm_unpinnable_folios(&movable_folio_list,
+ pofs);
if (!collected)
return 0;
Thanks!
Acked-by: David Hildenbrand <david@xxxxxxxxxx>
Appreciate the ack, and of course the idea and implementation as well! :)
thanks,
--
John Hubbard
