On Tue, Nov 05, 2024 at 12:31:36AM +0000, Matthew Wilcox wrote: > On Mon, Nov 04, 2024 at 02:27:33PM -0800, Keren Sun wrote: > > The patch series fixes 1 error and 27 warnings found by checkpatch.pl in the > > memcg1 code. > > Please do not do this. Fixing checkpatch messages in existing code > is counterproductive. Only run checkpatch on new code, and even then > take its suggestions with a grain of salt. I do agree in general, but not in this case. These are nice cleanups no matter what checkpatch.pl thinks of it :) Thanks!