Re: [PATCH] maple_tree: use KMEM_CACHE to create maple_node caches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 04, 2024 at 02:16:17PM +0800, Ke Sun wrote:
> Use the KMEM_CACHE() macro instead of kmem_cache_create() to simplify
> the creation of SLAB caches.

Did you even test this?  It is REQUIRED that maple_node be aligned to
its size (eg 256 bytes) as the bottom bits of pointers to nodes are used
for other purposes.  KMEM_CACHE() does not give us this guarantee.

NACK.




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux