On Fri, Oct 25, 2024, at 19:21, James Houghton wrote: > Hi Andrew, > > The following diff applied to the second patch[1] fixes this error. The > diff is functionally a no-op; the get_pmd_pfn() immediately following > the code here would return -1 in the !pmd_present() case. > > I can send a brand new patch if you'd prefer. > > [1]: > https://lore.kernel.org/linux-mm/20241019012940.3656292-3-jthoughton@xxxxxxxxxx/ I ran into another problem with the build failure below, and found that your fixup address this as well. Arnd In file included from <command-line>: In function 'pmdp_test_and_clear_young', inlined from 'walk_pmd_range_locked.constprop.isra' at mm/vmscan.c:3504:8: include/linux/compiler_types.h:517:45: error: call to '__compiletime_assert_401' declared with attribute error: BUILD_BUG failed 517 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^ include/linux/compiler_types.h:498:25: note: in definition of macro '__compiletime_assert' 498 | prefix ## suffix(); \ | ^~~~~~ include/linux/compiler_types.h:517:9: note: in expansion of macro '_compiletime_assert' 517 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__) | ^~~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) | ^~~~~~~~~~~~~~~~~~ include/linux/build_bug.h:59:21: note: in expansion of macro 'BUILD_BUG_ON_MSG' 59 | #define BUILD_BUG() BUILD_BUG_ON_MSG(1, "BUILD_BUG failed") | ^~~~~~~~~~~~~~~~ include/linux/pgtable.h:383:9: note: in expansion of macro 'BUILD_BUG' 383 | BUILD_BUG(); | ^~~~~~~~~
