On Sun, 20 Oct 2024 at 10:04, Kent Overstreet <kent.overstreet@xxxxxxxxx> wrote: > > But given that vmalloc() already supports > INT_MAX requests, and memory > sizes keep growing so 2GB is getting pretty small - I think it's time, > this is going to come up in other places sooner or later. No. If you need 2GB+ memory for filesystem operations, you fix your code. 2GB is more than you *can* allocate on 32-bit platforms, and even on 64-bit ones it is often quite a lot. So even aside from the *fact* of integer overflows, that check isn't going away. Linus