On Wed, Oct 16, 2024 at 12:44:18PM -0700, Dave Hansen wrote: > Would anybody hate if we broke this up a bit, like: > > const typeof(var) _val = val; > const int paoconst = __builtin_constant_p(val); > const int paoinc = paoconst && ((_val) == 1); > const int paodec = paoconst && ((_val) == (typeof(var))-1); > > and then did > > if (paoinc) > percpu_unary_op(size, qual, "inc", var); > ... I think that is an overall improvement. Proceed! :-)