On 2024/10/16 20:34, Kefeng Wang wrote:
On 2024/10/16 18:09, Baolin Wang wrote:
Use iocb->ki_pos to check if the read bytes exceeds the file size and to
calculate the bytes to be read can help simplify the code logic.
Meanwhile,
this is also a preparation for improving tmpfs large folios read
performace
in the following patch.
Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>
---
mm/shmem.c | 36 ++++++++++++------------------------
1 file changed, 12 insertions(+), 24 deletions(-)
diff --git a/mm/shmem.c b/mm/shmem.c
index 66eae800ffab..edab02a26aac 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -3106,26 +3106,18 @@ static ssize_t shmem_file_read_iter(struct
kiocb *iocb, struct iov_iter *to)
unsigned long offset;
int error = 0;
ssize_t retval = 0;
- loff_t *ppos = &iocb->ki_pos;
- index = *ppos >> PAGE_SHIFT;
- offset = *ppos & ~PAGE_MASK;
+ index = iocb->ki_pos >> PAGE_SHIFT;
index calculate could be moved before shmem_get_folio(), then...
Yes. Will do.
