On Mon, Oct 14, 2024 at 1:27 PM Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> wrote: > > On Sun, Oct 13, 2024 at 12:56 AM Shakeel Butt <shakeel.butt@xxxxxxxxx> wrote: > > > > On Thu, Oct 10, 2024 at 01:56:41PM GMT, Andrii Nakryiko wrote: > > > From: Suren Baghdasaryan <surenb@xxxxxxxxxx> > > > > > > Add helper functions to speculatively perform operations without > > > read-locking mmap_lock, expecting that mmap_lock will not be > > > write-locked and mm is not modified from under us. > > > > > > Suggested-by: Peter Zijlstra <peterz@xxxxxxxxxxxxx> > > > Signed-off-by: Suren Baghdasaryan <surenb@xxxxxxxxxx> > > > Signed-off-by: Andrii Nakryiko <andrii@xxxxxxxxxx> > > > Link: https://lore.kernel.org/bpf/20240912210222.186542-1-surenb@xxxxxxxxxx > > > > Looks good to me. mmap_lock_speculation_* functions could use kerneldoc > > but that can be added later. > > Yep, though probably best if Suren can do that in the follow up, as he > knows all the right words to use :) Will add to my TODO list. > > > > > Reviewed-by: Shakeel Butt <shakeel.butt@xxxxxxxxx> > > > > Thanks! > > >
