On Thu, 19 Sept 2024 at 06:16, Dimitri Sivanich <sivanich@xxxxxxx> wrote: > > Disabling preemption in the GRU driver is unnecessary, and clashes with > sleeping locks in several code paths. Remove preempt_disable and > preempt_enable from the GRU driver. I've applied this directly, since it didn't come in through any of the normal channels, and I don't see it pending anywhere in linux-next either. I doubt it matters much in practice, but at least it should make smatch happier about this driver, and clearly the preemption disabling was always wrong. Linus