On Tue, Oct 08, 2024 at 10:52:00AM +0800, Huang, Ying wrote: > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes: > > On Fri, Sep 06, 2024 at 09:07:41AM +0800, Huang, Ying wrote: > >> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes: > >> > On Wed, Sep 04, 2024 at 04:58:20PM -0700, Dan Williams wrote: > >> >> Huang, Ying wrote: > >> >> > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes: [..] > >> >> > > You may move Cc list after '---', so it won't unnecessarily pollute the commit > >> >> > > message. > >> >> > > >> >> > Emm... It appears that it's a common practice to include "Cc" in the > >> >> > commit log. > >> >> > >> >> Yes, just ignore this feedback, it goes against common practice. Cc list > >> >> as is looks sane to me. > >> > > >> > It seems nobody can give technical arguments why it's better than just keeping > >> > them outside of the commit message. Mantra "common practice" nowadays is > >> > questionable. > >> > >> Cc list is used by 0day test robot to notify relevant developers and > >> maintainers in addition to the author when reporting regressions. That > >> is helpful information. > > > > I'm not objecting Cc email tags, I'm objecting having them in the commit messages! > > Can you explain, how useful they are when they are placed as part of commit message > > bodies? > > The result of regression bisection is the first bad commit. Where we > use the Cc list in commit message to help find out whom we should send > the report email to. We have all tags and MAINTAINERS database. How do you know if those who are in the Cc list are really interested in receiving this? What make me sure is to have Author of the culprit commit, relevant mailing list and maintainers, also reviewers and testers, if any. All this information is available without Cc list. But if you *really* want it, you should follow the Link tag (for the new commits, for the past ~2+ years) and harvest it there. And actually I use that Link to reply to the thread directly. So, again, the Cc list in the commit message is a historical burden that consumes a lot of time and energy and should be gone in the future. -- With Best Regards, Andy Shevchenko
