[linux-next:master 2562/2853] sound/soc/codecs/rt-sdw-common.c:87: warning: Function parameter or struct member 'val' not described in 'rt_sdca_index_update_bits'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jack,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   33ce24234fca4c083e6685a18b460a18ebb5d5c1
commit: 86ce355c1f9ab943bbe099ea7d0b8a3af2247f65 [2562/2853] ASoC: rt721-sdca: Add RT721 SDCA driver
config: i386-buildonly-randconfig-006-20241008 (https://download.01.org/0day-ci/archive/20241008/202410081909.i3j7cibD-lkp@xxxxxxxxx/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241008/202410081909.i3j7cibD-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410081909.i3j7cibD-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> sound/soc/codecs/rt-sdw-common.c:119:3: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
     119 |                 ret |= SND_JACK_BTN_2;
         |                 ^~~
   sound/soc/codecs/rt-sdw-common.c:111:9: note: initialize the variable 'ret' to silence this warning
     111 |         int ret;
         |                ^
         |                 = 0
   1 warning generated.
--
>> sound/soc/codecs/rt-sdw-common.c:87: warning: Function parameter or struct member 'val' not described in 'rt_sdca_index_update_bits'
>> sound/soc/codecs/rt-sdw-common.c:87: warning: Excess function parameter 'value' description in 'rt_sdca_index_update_bits'
--
>> sound/soc/codecs/rt721-sdca.c:45:7: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
      45 |                 if (ret < 0)
         |                     ^~~
   sound/soc/codecs/rt721-sdca.c:33:23: note: initialize the variable 'ret' to silence this warning
      33 |         int btn_type = 0, ret;
         |                              ^
         |                               = 0
   1 warning generated.

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for GET_FREE_REGION
   Depends on [n]: SPARSEMEM [=n]
   Selected by [y]:
   - RESOURCE_KUNIT_TEST [=y] && RUNTIME_TESTING_MENU [=y] && KUNIT [=y]


vim +87 sound/soc/codecs/rt-sdw-common.c

bbca8e7050e076 Jack Yu 2024-10-01   71  
bbca8e7050e076 Jack Yu 2024-10-01   72  /**
bbca8e7050e076 Jack Yu 2024-10-01   73   * rt_sdca_index_update_bits - Update value on Realtek defined register.
bbca8e7050e076 Jack Yu 2024-10-01   74   *
bbca8e7050e076 Jack Yu 2024-10-01   75   * @map: map for setting.
bbca8e7050e076 Jack Yu 2024-10-01   76   * @nid: Realtek-defined ID.
bbca8e7050e076 Jack Yu 2024-10-01   77   * @reg: register.
bbca8e7050e076 Jack Yu 2024-10-01   78   * @mask: Bitmask to change
bbca8e7050e076 Jack Yu 2024-10-01   79   * @value: New value for bitmask
bbca8e7050e076 Jack Yu 2024-10-01   80   *
bbca8e7050e076 Jack Yu 2024-10-01   81   * A value of zero will be returned on success, a negative errno will
bbca8e7050e076 Jack Yu 2024-10-01   82   * be returned in error cases.
bbca8e7050e076 Jack Yu 2024-10-01   83   */
bbca8e7050e076 Jack Yu 2024-10-01   84  
bbca8e7050e076 Jack Yu 2024-10-01   85  int rt_sdca_index_update_bits(struct regmap *map,
bbca8e7050e076 Jack Yu 2024-10-01   86  	unsigned int nid, unsigned int reg, unsigned int mask, unsigned int val)
bbca8e7050e076 Jack Yu 2024-10-01  @87  {
bbca8e7050e076 Jack Yu 2024-10-01   88  	unsigned int tmp;
bbca8e7050e076 Jack Yu 2024-10-01   89  	int ret;
bbca8e7050e076 Jack Yu 2024-10-01   90  
bbca8e7050e076 Jack Yu 2024-10-01   91  	ret = rt_sdca_index_read(map, nid, reg, &tmp);
bbca8e7050e076 Jack Yu 2024-10-01   92  	if (ret < 0)
bbca8e7050e076 Jack Yu 2024-10-01   93  		return ret;
bbca8e7050e076 Jack Yu 2024-10-01   94  
bbca8e7050e076 Jack Yu 2024-10-01   95  	set_mask_bits(&tmp, mask, val);
bbca8e7050e076 Jack Yu 2024-10-01   96  	return rt_sdca_index_write(map, nid, reg, tmp);
bbca8e7050e076 Jack Yu 2024-10-01   97  }
bbca8e7050e076 Jack Yu 2024-10-01   98  EXPORT_SYMBOL_GPL(rt_sdca_index_update_bits);
bbca8e7050e076 Jack Yu 2024-10-01   99  
bbca8e7050e076 Jack Yu 2024-10-01  100  /**
bbca8e7050e076 Jack Yu 2024-10-01  101   * rt_sdca_btn_type - Decision of button type.
bbca8e7050e076 Jack Yu 2024-10-01  102   *
bbca8e7050e076 Jack Yu 2024-10-01  103   * @buffer: UMP message buffer.
bbca8e7050e076 Jack Yu 2024-10-01  104   *
bbca8e7050e076 Jack Yu 2024-10-01  105   * A button type will be returned regarding to buffer,
bbca8e7050e076 Jack Yu 2024-10-01  106   * it returns zero if buffer cannot be recognized.
bbca8e7050e076 Jack Yu 2024-10-01  107   */
bbca8e7050e076 Jack Yu 2024-10-01  108  int rt_sdca_btn_type(unsigned char *buffer)
bbca8e7050e076 Jack Yu 2024-10-01  109  {
bbca8e7050e076 Jack Yu 2024-10-01  110  	u8 btn_type = 0;
bbca8e7050e076 Jack Yu 2024-10-01  111  	int ret;
bbca8e7050e076 Jack Yu 2024-10-01  112  
bbca8e7050e076 Jack Yu 2024-10-01  113  	btn_type |= buffer[0] & 0xf;
bbca8e7050e076 Jack Yu 2024-10-01  114  	btn_type |= (buffer[0] >> 4) & 0xf;
bbca8e7050e076 Jack Yu 2024-10-01  115  	btn_type |= buffer[1] & 0xf;
bbca8e7050e076 Jack Yu 2024-10-01  116  	btn_type |= (buffer[1] >> 4) & 0xf;
bbca8e7050e076 Jack Yu 2024-10-01  117  
bbca8e7050e076 Jack Yu 2024-10-01  118  	if (btn_type & BIT(0))
bbca8e7050e076 Jack Yu 2024-10-01 @119  		ret |= SND_JACK_BTN_2;
bbca8e7050e076 Jack Yu 2024-10-01  120  	if (btn_type & BIT(1))
bbca8e7050e076 Jack Yu 2024-10-01  121  		ret |= SND_JACK_BTN_3;
bbca8e7050e076 Jack Yu 2024-10-01  122  	if (btn_type & BIT(2))
bbca8e7050e076 Jack Yu 2024-10-01  123  		ret |= SND_JACK_BTN_0;
bbca8e7050e076 Jack Yu 2024-10-01  124  	if (btn_type & BIT(3))
bbca8e7050e076 Jack Yu 2024-10-01  125  		ret |= SND_JACK_BTN_1;
bbca8e7050e076 Jack Yu 2024-10-01  126  
bbca8e7050e076 Jack Yu 2024-10-01  127  	return ret;
bbca8e7050e076 Jack Yu 2024-10-01  128  }
bbca8e7050e076 Jack Yu 2024-10-01  129  EXPORT_SYMBOL_GPL(rt_sdca_btn_type);
bbca8e7050e076 Jack Yu 2024-10-01  130  

:::::: The code at line 87 was first introduced by commit
:::::: bbca8e7050e0769d46eb775082d1926db05e7dac ASoC: rt-sdw-common: Common functions for Realtek soundwire driver

:::::: TO: Jack Yu <jack.yu@xxxxxxxxxxx>
:::::: CC: Mark Brown <broonie@xxxxxxxxxx>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux