On Mon, Oct 07, 2024 at 04:41:09PM -0400, Rodrigo Vivi wrote: > On Fri, Oct 04, 2024 at 09:50:36PM +0800, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: 58ca61c1a866bfdaa5e19fb19a2416764f847d75 > > commit: 91b2c42c214f570efaff80a666e30b8f6ce4f12b [2050/2483] drm/xe: Use fault injection infrastructure to find issues at probe time > > config: i386-buildonly-randconfig-003-20241004 (https://download.01.org/0day-ci/archive/20241004/202410042155.On1ck1h8-lkp@xxxxxxxxx/config) > > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241004/202410042155.On1ck1h8-lkp@xxxxxxxxx/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202410042155.On1ck1h8-lkp@xxxxxxxxx/ > > > > Note: the linux-next/master HEAD 58ca61c1a866bfdaa5e19fb19a2416764f847d75 builds fine. > > It may have been fixed somewhere. > > > > All errors (new ones prefixed by >>): > > > > In file included from drivers/gpu/drm/xe/xe_guc_ads.c:8: > > >> include/linux/fault-inject.h:97:15: error: unknown type name 'bool' > > 97 | static inline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order) > > | ^~~~ > > >> include/linux/fault-inject.h:97:43: error: unknown type name 'gfp_t' > > 97 | static inline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order) > > | ^~~~~ > > include/linux/fault-inject.h:106:57: error: unknown type name 'gfp_t' > > 106 | static inline int should_failslab(struct kmem_cache *s, gfp_t gfpflags) > > | ^~~~~ > > > > > > I thought that had been fixed by commit > 6ce2082fd3a2 ("fault-inject: improve build for CONFIG_FAULT_INJECTION=n") > > but it looks like some config case missing still? Not sure about the sequence here but the fix 6ce2082fd3a2 was indeed missing when building from 91b2c42c214f, see "commit:" above and [1]. When building HEAD, the fix is present before the new commit, as it should be, which explains the note above "the linux-next/master HEAD 58ca61c1a866bfdaa5e19fb19a2416764f847d75 builds fine". So it looks fine to me. [1] https://download.01.org/0day-ci/archive/20241004/202410042155.On1ck1h8-lkp@xxxxxxxxx/reproduce Francois > > > vim +/bool +97 include/linux/fault-inject.h > > > > cc689c5b352d4a Ingo Molnar 2017-02-01 93 > > 0866e82e40fba4 Kefeng Wang 2023-05-16 94 #ifdef CONFIG_FAIL_PAGE_ALLOC > > 53dabce2652fb8 Vlastimil Babka 2024-07-11 95 bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order); > > 0866e82e40fba4 Kefeng Wang 2023-05-16 96 #else > > 53dabce2652fb8 Vlastimil Babka 2024-07-11 @97 static inline bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order) > > 0866e82e40fba4 Kefeng Wang 2023-05-16 98 { > > 0866e82e40fba4 Kefeng Wang 2023-05-16 99 return false; > > 0866e82e40fba4 Kefeng Wang 2023-05-16 100 } > > 0866e82e40fba4 Kefeng Wang 2023-05-16 101 #endif /* CONFIG_FAIL_PAGE_ALLOC */ > > 0866e82e40fba4 Kefeng Wang 2023-05-16 102 > > > > :::::: The code at line 97 was first introduced by commit > > :::::: 53dabce2652fb854eae84609ce9c37429d5d87ba mm, page_alloc: put should_fail_alloc_page() back behing CONFIG_FAIL_PAGE_ALLOC > > > > :::::: TO: Vlastimil Babka <vbabka@xxxxxxx> > > :::::: CC: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > > > > -- > > 0-DAY CI Kernel Test Service > > https://github.com/intel/lkp-tests/wiki
