On Thu, Sep 05, 2024 at 02:37:06PM -0700, Dan Williams wrote: > Andy Shevchenko wrote: > > On Wed, Sep 04, 2024 at 04:58:20PM -0700, Dan Williams wrote: > > > Huang, Ying wrote: > > > > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes: [..] > > > > > You may move Cc list after '---', so it won't unnecessarily pollute the commit > > > > > message. > > > > > > > > Emm... It appears that it's a common practice to include "Cc" in the > > > > commit log. > > > > > > Yes, just ignore this feedback, it goes against common practice. Cc list > > > as is looks sane to me. > > > > It seems nobody can give technical arguments why it's better than just keeping > > them outside of the commit message. Mantra "common practice" nowadays is > > questionable. > > Yes, question asked and answered. Not to your satisfaction, but the > people that have engaged to date have been cold to the idea. It's just matter if we care or not (about the environment, about performance in reviewing the code, about people who might use small screens or smartphones for reading the changes, et cetera). Even status quo should be questioned from time to time. > Historically, reaching into other kernel developers workflows to > instantiate a new preference is a high risk low reward endeavor, please > moderate your advocacy accordingly. Yeah, I got it... -- With Best Regards, Andy Shevchenko
