On 02.10.24 19:35, Dave Hansen wrote:
We were just chatting about this on David Rientjes's MM alignment call.
I thought I'd try to give a little brain
Let's start by thinking about KVM and secondary MMUs. KVM has a primary
mm: the QEMU (or whatever) process mm. The virtualization (EPT/NPT)
tables get entries that effectively mirror the primary mm page tables
and constitute a secondary MMU. If the primary page tables change,
mmu_notifiers ensure that the changes get reflected into the
virtualization tables and also that the virtualization paging structure
caches are flushed.
msharefs is doing something very similar. But, in the msharefs case,
the secondary MMUs are actually normal CPU MMUs. The page tables are
normal old page tables and the caches are the normal old TLB. That's
what makes it so confusing: we have lots of infrastructure for dealing
with that "stuff" (CPU page tables and TLB), but msharefs has
short-circuited the infrastructure and it doesn't work any more.
Basically, I think it makes a lot of sense to check what KVM (or another
mmu_notifier user) is doing and make sure that msharefs is following its
lead. For instance, KVM _should_ have the exact same "page free"
flushing issue where it gets the MMU notifier call but the page may
still be in the secondary MMU. I _think_ KVM fixes it with an extra
page refcount that it takes when it first walks the primary page tables.
Forgot to comment on this (brain still recovering ...).
KVM only grabs a temporary reference, and drops that reference once the
secondary MMU PTE was updated (present PTE installed). The notifiers on
primary MMU changes (e.g., unmap) take care of any TLB invalidation
before the primary MMU let's go of the page and the refcount is dropped.
--
Cheers,
David / dhildenb
