Re: [RFC PATCH 1/4] compiler.h: Introduce ptr_eq() to preserve address dependency

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>
Subject: Re: [RFC PATCH 1/4] compiler.h: Introduce ptr_eq() to preserve address dependency
From: Joel Fernandes <joel@xxxxxxxxxxxxxxxxx>
Date: Thu, 3 Oct 2024 18:09:48 -0400
Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Nicholas Piggin <npiggin@xxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>, "Paul E. McKenney" <paulmck@xxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Boqun Feng <boqun.feng@xxxxxxxxx>, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>, John Stultz <jstultz@xxxxxxxxxx>, Neeraj Upadhyay <Neeraj.Upadhyay@xxxxxxx>, Frederic Weisbecker <frederic@xxxxxxxxxx>, Josh Triplett <josh@xxxxxxxxxxxxxxxx>, Uladzislau Rezki <urezki@xxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Lai Jiangshan <jiangshanlai@xxxxxxxxx>, Zqiang <qiang.zhang1211@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Waiman Long <longman@xxxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, maged.michael@xxxxxxxxx, Mateusz Guzik <mjguzik@xxxxxxxxx>, Jonas Oberhauser <jonas.oberhauser@xxxxxxxxxxxxxxx>, rcu@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, lkmm@xxxxxxxxxxxxxxx, Gary Guo <gary@xxxxxxxxxxx>, Nikita Popov <github@xxxxxxxxxx>, llvm@xxxxxxxxxxxxxxx
In-reply-to: <7cc83ffc-c9cc-4e87-a3ee-bb62588a594c@efficios.com>
References: <20241002010205.1341915-1-mathieu.desnoyers@efficios.com> <20241002010205.1341915-2-mathieu.desnoyers@efficios.com> <20241003000843.GA192403@google.com> <7cc83ffc-c9cc-4e87-a3ee-bb62588a594c@efficios.com>

On Thu, Oct 3, 2024 at 10:21 AM Mathieu Desnoyers
<mathieu.desnoyers@xxxxxxxxxxxx> wrote:
> >
> > Reviewed-by: Joel Fernandes (Google) <joel@xxxxxxxxxxxxxxxxx>
>
> Please double-check with -O2, and let me know if you still agree with
> the patch :)
>

You are quite right, with -O2 I can indeed see that the optimize hide
var fixes it.

FWIW:
Tested-by: Joel Fernandes (Google) <joel@xxxxxxxxxxxxxxxxx>

Thanks!

 - Joel

References:
- [RFC PATCH 0/4] sched+mm: Track lazy active mm existence with hazard pointers
  - From: Mathieu Desnoyers
- [RFC PATCH 1/4] compiler.h: Introduce ptr_eq() to preserve address dependency
  - From: Mathieu Desnoyers
- Re: [RFC PATCH 1/4] compiler.h: Introduce ptr_eq() to preserve address dependency
  - From: Joel Fernandes
- Re: [RFC PATCH 1/4] compiler.h: Introduce ptr_eq() to preserve address dependency
  - From: Mathieu Desnoyers

Prev by Date: Re: [PATCH v7 25/26] kbuild: rust: remove the `alloc` crate and `GlobalAlloc`
Next by Date: Re: [PATCH] mm: avoid unconditional one-tick sleep when swapcache_prepare fails
Previous by thread: Re: [RFC PATCH 1/4] compiler.h: Introduce ptr_eq() to preserve address dependency
Next by thread: [RFC PATCH 3/4] hp: Implement Hazard Pointers
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]