On 10/2/24 21:48, Anshuman Khandual wrote: > set_pxd_safe() helpers that serve a specific purpose for both x86 and riscv > platforms, do not need to be in the common memory code. Otherwise they just > unnecessarily make the common API more complicated. This moves the helpers > from common code to platform instead. I looked into the x86 side a bit. I'm pretty sure we can just remove the _safe variants. All they do is spew warnings that don't seem to be doing any good. They're not really safer in any meaningful way. I've got a series cooked up to zap them, but I need to get some eyeballs on it. But if Andrew wants to pick this up any carry it in the meantime since it's cross-arch I'm fine with it: Acked-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>