[linux-next:master 1015/1347] fs/jfs/super.c:392 jfs_reconfigure() warn: inconsistent indenting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   77df9e4bb2224d8ffbddec04c333a9d7965dad6c
commit: 384011cabd9778cccac6c834e6164b4cb3b6f8f3 [1015/1347] jfs: convert jfs to use the new mount api
config: x86_64-randconfig-161-20241001 (https://download.01.org/0day-ci/archive/20241001/202410011512.W2ftUq9U-lkp@xxxxxxxxx/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410011512.W2ftUq9U-lkp@xxxxxxxxx/

smatch warnings:
fs/jfs/super.c:392 jfs_reconfigure() warn: inconsistent indenting

vim +392 fs/jfs/super.c

   360	
   361	static int jfs_reconfigure(struct fs_context *fc)
   362	{
   363		struct jfs_context *ctx = fc->fs_private;
   364		struct super_block *sb = fc->root->d_sb;
   365		int readonly = fc->sb_flags & SB_RDONLY;
   366		int rc = 0;
   367		int flag = ctx->flag;
   368		int ret;
   369	
   370		sync_filesystem(sb);
   371	
   372		/* Transfer results of parsing to the sbi */
   373		JFS_SBI(sb)->flag = ctx->flag;
   374		JFS_SBI(sb)->uid = ctx->uid;
   375		JFS_SBI(sb)->gid = ctx->gid;
   376		JFS_SBI(sb)->umask = ctx->umask;
   377		JFS_SBI(sb)->minblks_trim = ctx->minblks_trim;
   378		if (ctx->nls_map != (void *) -1) {
   379			unload_nls(JFS_SBI(sb)->nls_tab);
   380			JFS_SBI(sb)->nls_tab = ctx->nls_map;
   381		}
   382		ctx->nls_map = NULL;
   383	
   384		if (ctx->resize) {
   385			if (sb_rdonly(sb)) {
   386				pr_err("JFS: resize requires volume to be mounted read-write\n");
   387				return -EROFS;
   388			}
   389	
   390			if (!ctx->newLVSize) {
   391				ctx->newLVSize = sb_bdev_nr_blocks(sb);
 > 392					if (ctx->newLVSize == 0)
   393						pr_err("JFS: Cannot determine volume size\n");
   394			}
   395	
   396			rc = jfs_extendfs(sb, ctx->newLVSize, 0);
   397			if (rc)
   398				return rc;
   399		}
   400	
   401		if (sb_rdonly(sb) && !readonly) {
   402			/*
   403			 * Invalidate any previously read metadata.  fsck may have
   404			 * changed the on-disk data since we mounted r/o
   405			 */
   406			truncate_inode_pages(JFS_SBI(sb)->direct_inode->i_mapping, 0);
   407	
   408			JFS_SBI(sb)->flag = flag;
   409			ret = jfs_mount_rw(sb, 1);
   410	
   411			/* mark the fs r/w for quota activity */
   412			sb->s_flags &= ~SB_RDONLY;
   413	
   414			dquot_resume(sb, -1);
   415			return ret;
   416		}
   417		if (!sb_rdonly(sb) && readonly) {
   418			rc = dquot_suspend(sb, -1);
   419			if (rc < 0)
   420				return rc;
   421			rc = jfs_umount_rw(sb);
   422			JFS_SBI(sb)->flag = flag;
   423			return rc;
   424		}
   425		if ((JFS_SBI(sb)->flag & JFS_NOINTEGRITY) != (flag & JFS_NOINTEGRITY)) {
   426			if (!sb_rdonly(sb)) {
   427				rc = jfs_umount_rw(sb);
   428				if (rc)
   429					return rc;
   430	
   431				JFS_SBI(sb)->flag = flag;
   432				ret = jfs_mount_rw(sb, 1);
   433				return ret;
   434			}
   435		}
   436		JFS_SBI(sb)->flag = flag;
   437	
   438		return 0;
   439	}
   440	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux