On Thu, 12 Sep 2024 00:52:46 +0200 Danilo Krummrich <dakr@xxxxxxxxxx> wrote: > Now that we got the kernel `Box` type in place, convert all existing > `Box` users to make use of it. > > Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx> > Reviewed-by: Benno Lossin <benno.lossin@xxxxxxxxx> > Signed-off-by: Danilo Krummrich <dakr@xxxxxxxxxx> Reviewed-by: Gary Guo <gary@xxxxxxxxxxx> Have you considered defaulting the `A` in `Box` to `Kmalloc`? This would avoid doing a lot of tree-wide changes. If you have a reason against it (I'm pretty sure you have), then probably you should put it in the commit message. Best, Gary > --- > drivers/block/rnull.rs | 4 +-- > rust/kernel/init.rs | 51 ++++++++++++++++--------------- > rust/kernel/init/__internal.rs | 2 +- > rust/kernel/rbtree.rs | 49 ++++++++++++++++------------- > rust/kernel/sync/arc.rs | 17 +++++------ > rust/kernel/sync/condvar.rs | 4 +-- > rust/kernel/sync/lock/mutex.rs | 2 +- > rust/kernel/sync/lock/spinlock.rs | 2 +- > rust/kernel/workqueue.rs | 20 ++++++------ > rust/macros/lib.rs | 6 ++-- > 10 files changed, 81 insertions(+), 76 deletions(-)
