On Wed, Sep 25, 2024 at 7:27 AM Johannes Weiner <hannes@xxxxxxxxxxx> wrote: > > On Mon, Sep 23, 2024 at 06:17:07PM -0700, Kanchana P Sridhar wrote: > > zswap_store() will now store mTHP and PMD-size THP folios by compressing > > The hugepage terminology throughout the patches is a bit convoluted. > > There is no real distinction in this code between PMD-size THPs and > sub-PMD-sized mTHPs e.g. In particular, I think "mTHP" made sense when > they were added, to distinguish them from conventional THPs. But using > this term going forward just causes confusion, IMO. > > We're going through a big effort in the codebase to call all of these > things simply "folios" - which stands for "one or more pages". If you > want to emphasize the "more than one page", the convention is to call > it a "large folio". (If you need to emphasize that it's PMD size - > which doesn't apply to these patches, but just for the record - the > convention is "pmd-mappable folio".) > > So what this patch set does is "support large folios in zswap". Agreed on all of this, except it should be "support large folios in zswap _stores". We don't really support loading large folios.
