On Wed, Sep 25, 2024 at 7:21 AM Nhat Pham <nphamcs@xxxxxxxxx> wrote: > > On Wed, Sep 25, 2024 at 12:33 AM Barry Song <baohua@xxxxxxxxxx> wrote: > How does this look? My concern is that there is not really a use for > the fallback logic. Basically dead code. > > I can keep it in if you guys have a use for it soon, but otherwise I > lean towards just adding a WARN etc. there, or return -ENOMEM, and > WARN at shmem's callsite (because it cannot get -ENOMEM). Oh and another point - I plan to rewrite this swap entity lifetime logic in the new abstraction layer. The swap continuation part will go away with it - I don't quite like the way we're currently doing things. So this added complexity might be unnecessary.
