On Wed, Sep 25, 2024 at 10:26 AM Alice Ryhl <aliceryhl@xxxxxxxxxx> wrote: > > On Mon, Sep 16, 2024 at 6:47 PM Miguel Ojeda > <miguel.ojeda.sandonis@xxxxxxxxx> wrote: > > > > On Mon, Sep 16, 2024 at 6:15 PM Miguel Ojeda > > <miguel.ojeda.sandonis@xxxxxxxxx> wrote: > > > > > > Applied to `rust-next` -- thanks everyone! > > > > Also, for KASAN + RETHUNK builds, I noticed objtool detects this: > > > > samples/rust/rust_print.o: warning: objtool: > > asan.module_ctor+0x17: 'naked' return found in MITIGATION_RETHUNK > > build > > samples/rust/rust_print.o: warning: objtool: > > asan.module_dtor+0x17: 'naked' return found in MITIGATION_RETHUNK > > build > > > > And indeed from a quick look the `ret` is there. > > > > Since KASAN support is important, I decided to take it nevertheless, > > but please let's make sure this is fixed during the cycle (or add a > > "depends on"). > > I figured out what the problem is. I will follow up with a fix soon. I posted a fix: https://github.com/rust-lang/rust/pull/130824 We'll need a check on RUSTC_VERSION in Kconfig for this. If the PR gets merged within the next 22 days, this will land in 1.83.0. Would you like me to send a fix with that version number now or wait for it to get merged before I send that fix? Alice
