On Wed, Sep 25, 2024 at 09:44:40AM GMT, Lorenzo Stoakes wrote:
> TL;DR: NACK because you sent two conflicting non-RFC patches as
> 'alternatives', which is not how development on-list works. Please resend
> maybe one of these as an RFC...
[snip]
> On Wed, Sep 25, 2024 at 04:16:28PM GMT, Shu Han wrote:
> > This patch moves the security_file_mmap() back into do_mmap(), which
> > revert the commit 8b3ec6814c83d76b85bd13badc48552836c24839
> > ("take security_mmap_file() outside of ->mmap_sem"). Below is the reason.
>
[snip]
Having said all the previous stuff - do_mmap() and mmap_region() very badly
need at the very least comments to explain how the interfaces differ and
what is provided (including in security terms).
Perhaps we need to go a bit further and audit how exactly they're used.
I'll add that to my TODO list!
