On Tue, Sep 24, 2024 at 09:13:52PM GMT, Al Viro wrote: > On Tue, Sep 24, 2024 at 09:10:23PM +0100, Lorenzo Stoakes wrote: > > + if (IS_ERR(mm)) > > + return PTR_ERR(mm) == -ESRCH ? NULL : mm; > > Pet peeve: what's wrong with mm == ERR_PTR(-ESRCH)? Ha, yeah I'm easy either way, though your version is less ugly than mine (and places the macro/constants together which is clearer) so let's go with that... Andrew - fix-patch attached, please apply. Thanks! ----8<----