On Tue, Sep 24, 2024 at 3:16 PM Nhat Pham <nphamcs@xxxxxxxxx> wrote: > > On Tue, Sep 24, 2024 at 2:34 PM Yosry Ahmed <yosryahmed@xxxxxxxxxx> wrote: > > > > > > Why can't we just handle it the same way as we handle zswap > > disablement? If it is disabled, we invalidate any old entries for the > > offsets and return false to swapout to disk. > > I think that was the suggestion. Hmm I may be reading this wrong, but my understanding was that the suggestion is to synchronously remove all entries of large folios from zswap when zswap_mthp is disabled. What I am suggesting is to do the same thing we do in zswap_store() when zswap is disabled. Anyway, if we are removing the knob this is not relevant anymore.