On Thu, Aug 16, 2012 at 10:30 PM, Glauber Costa <glommer@xxxxxxxxxxxxx> wrote: > On 08/17/2012 12:53 AM, Ying Han wrote: >> Add target_mem_cgroup and mem_cgroup to shrink_control. The former one is the >> "root" memcg under pressure, and the latter one is the "current" memcg under >> pressure. >> >> The target_mem_cgroup is initialized with the scan_control's target_mem_cgroup >> under target reclaim and default to NULL for rest of the places including >> global reclaim. >> >> Signed-off-by: Ying Han <yinghan@xxxxxxxxxx> > > Maybe I'll change my mind while I advance in the patchset, but at first, > I don't see the point in having two memcg encoded in the shrinker > structure. It seems to me we should be able to do this internally from > memcg and hide it from the shrinker code. We can do something like scan_control has, and during shrink_zone() passes down the memcg context with lruvec. That is feasible as long as it is necessary. --Ying > > > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>