On 9/19/24 23:42, Anshuman Khandual wrote: >> I just did a quick grep and don't see any difference between the _safe >> and normal variants. A quick grep didn't turn up any actual users. >> >> Did anyone actually double check that these are still needed on x86 in >> the first place? > arch/x86/mm/init_64.c Ahh, the #defines make them immune to grep. :) Long-term, we should make sure these are still necessary. Short term (in this patch), please just put the #defines in init_64.c if it is the only site that needs them.