Re: [PATCH v1 1/1] maple_tree: Drop unused functions to fix the build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 06, 2024 at 11:26:26AM -0400, Liam R. Howlett wrote:
> This exists to stop people from using the bits while the feature is in
> active development.  We had the same patch a few days (weeks?) ago.

This breaks build. Can you propose better solution, please?

> * Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> [240906 11:05]:
> > A few functions defined but not used. This, in particular,
> > prevents kernel builds with clang, `make W=1` and CONFIG_WERROR=y:
> > 
> > lib/maple_tree.c:351:21: error: unused function 'mte_set_full' [-Werror,-Wunused-function]
> >   351 | static inline void *mte_set_full(const struct maple_enode *node)
> >       |                     ^~~~~~~~~~~~
> > lib/maple_tree.c:356:21: error: unused function 'mte_clear_full' [-Werror,-Wunused-function]
> >   356 | static inline void *mte_clear_full(const struct maple_enode *node)
> >       |                     ^~~~~~~~~~~~~~
> > lib/maple_tree.c:361:20: error: unused function 'mte_has_null' [-Werror,-Wunused-function]
> >   361 | static inline bool mte_has_null(const struct maple_enode *node)
> >       |                    ^~~~~~~~~~~~
> > 
> > Fix this by dropping unused functions.
> > 
> > See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static
> > inline functions for W=1 build").
> > 
> > Fixes: 6e7ba8b5e238 ("maple_tree: mte_set_full() and mte_clear_full() clang-analyzer clean up")
> > Fixes: 54a611b60590 ("Maple Tree: add new data structure")

-- 
With Best Regards,
Andy Shevchenko






[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux