[linux-next:master 10093/10296] fs/smb/client/cifssmb.c:1329:45: error: 'struct cifs_io_subrequest' has no member named 'actual_len'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   9aaeb87ce1e966169a57f53a02ba05b30880ffb8
commit: a58e60d6975bbd347715ec6e800ee44a3e62cd4f [10093/10296] Merge branch 'vfs.all' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
config: parisc-defconfig (https://download.01.org/0day-ci/archive/20240907/202409070016.5kDtPktX-lkp@xxxxxxxxx/config)
compiler: hppa-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240907/202409070016.5kDtPktX-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409070016.5kDtPktX-lkp@xxxxxxxxx/

Note: the linux-next/master HEAD 9aaeb87ce1e966169a57f53a02ba05b30880ffb8 builds fine.
      It may have been fixed somewhere.

All errors (new ones prefixed by >>):

   fs/smb/client/cifssmb.c: In function 'cifs_readv_callback':
>> fs/smb/client/cifssmb.c:1329:45: error: 'struct cifs_io_subrequest' has no member named 'actual_len'
    1329 |                 if (rdata->got_bytes < rdata->actual_len &&
         |                                             ^~


vim +1329 fs/smb/client/cifssmb.c

a68c74865f517e fs/smb/client/cifssmb.c David Howells   2024-09-03  1272  
e28bc5b1fdbd6e fs/cifs/cifssmb.c       Jeff Layton     2011-10-19  1273  static void
e28bc5b1fdbd6e fs/cifs/cifssmb.c       Jeff Layton     2011-10-19  1274  cifs_readv_callback(struct mid_q_entry *mid)
e28bc5b1fdbd6e fs/cifs/cifssmb.c       Jeff Layton     2011-10-19  1275  {
753b67eb630db3 fs/smb/client/cifssmb.c David Howells   2022-03-09  1276  	struct cifs_io_subrequest *rdata = mid->callback_data;
a68c74865f517e fs/smb/client/cifssmb.c David Howells   2024-09-03  1277  	struct netfs_inode *ictx = netfs_inode(rdata->rreq->inode);
3ee1a1fc398199 fs/smb/client/cifssmb.c David Howells   2023-10-06  1278  	struct cifs_tcon *tcon = tlink_tcon(rdata->req->cfile->tlink);
e28bc5b1fdbd6e fs/cifs/cifssmb.c       Jeff Layton     2011-10-19  1279  	struct TCP_Server_Info *server = tcon->ses->server;
738f9de5cdb917 fs/cifs/cifssmb.c       Pavel Shilovsky 2016-11-23  1280  	struct smb_rqst rqst = { .rq_iov = rdata->iov,
738f9de5cdb917 fs/cifs/cifssmb.c       Pavel Shilovsky 2016-11-23  1281  				 .rq_nvec = 2,
ab58fbdeebc7f9 fs/smb/client/cifssmb.c David Howells   2023-10-06  1282  				 .rq_iter = rdata->subreq.io_iter };
a68c74865f517e fs/smb/client/cifssmb.c David Howells   2024-09-03  1283  	struct cifs_credits credits = {
a68c74865f517e fs/smb/client/cifssmb.c David Howells   2024-09-03  1284  		.value = 1,
a68c74865f517e fs/smb/client/cifssmb.c David Howells   2024-09-03  1285  		.instance = 0,
a68c74865f517e fs/smb/client/cifssmb.c David Howells   2024-09-03  1286  		.rreq_debug_id = rdata->rreq->debug_id,
a68c74865f517e fs/smb/client/cifssmb.c David Howells   2024-09-03  1287  		.rreq_debug_index = rdata->subreq.debug_index,
a68c74865f517e fs/smb/client/cifssmb.c David Howells   2024-09-03  1288  	};
e28bc5b1fdbd6e fs/cifs/cifssmb.c       Jeff Layton     2011-10-19  1289  
ab58fbdeebc7f9 fs/smb/client/cifssmb.c David Howells   2023-10-06  1290  	cifs_dbg(FYI, "%s: mid=%llu state=%d result=%d bytes=%zu\n",
f96637be081141 fs/cifs/cifssmb.c       Joe Perches     2013-05-04  1291  		 __func__, mid->mid, mid->mid_state, rdata->result,
ab58fbdeebc7f9 fs/smb/client/cifssmb.c David Howells   2023-10-06  1292  		 rdata->subreq.len);
e28bc5b1fdbd6e fs/cifs/cifssmb.c       Jeff Layton     2011-10-19  1293  
7c9421e1a9ce8d fs/cifs/cifssmb.c       Pavel Shilovsky 2012-03-23  1294  	switch (mid->mid_state) {
e28bc5b1fdbd6e fs/cifs/cifssmb.c       Jeff Layton     2011-10-19  1295  	case MID_RESPONSE_RECEIVED:
e28bc5b1fdbd6e fs/cifs/cifssmb.c       Jeff Layton     2011-10-19  1296  		/* result already set, check signature */
38d77c50b4f4e3 fs/cifs/cifssmb.c       Jeff Layton     2013-05-26  1297  		if (server->sign) {
985e4ff016b5f3 fs/cifs/cifssmb.c       Steve French    2012-08-03  1298  			int rc = 0;
985e4ff016b5f3 fs/cifs/cifssmb.c       Steve French    2012-08-03  1299  
a68c74865f517e fs/smb/client/cifssmb.c David Howells   2024-09-03  1300  			iov_iter_truncate(&rqst.rq_iter, rdata->got_bytes);
bf5ea0e2f29b00 fs/cifs/cifssmb.c       Jeff Layton     2012-09-18  1301  			rc = cifs_verify_signature(&rqst, server,
0124cc45113f93 fs/cifs/cifssmb.c       Jeff Layton     2013-04-03  1302  						  mid->sequence_number);
985e4ff016b5f3 fs/cifs/cifssmb.c       Steve French    2012-08-03  1303  			if (rc)
f96637be081141 fs/cifs/cifssmb.c       Joe Perches     2013-05-04  1304  				cifs_dbg(VFS, "SMB signature verification returned error = %d\n",
f96637be081141 fs/cifs/cifssmb.c       Joe Perches     2013-05-04  1305  					 rc);
e28bc5b1fdbd6e fs/cifs/cifssmb.c       Jeff Layton     2011-10-19  1306  		}
e28bc5b1fdbd6e fs/cifs/cifssmb.c       Jeff Layton     2011-10-19  1307  		/* FIXME: should this be counted toward the initiating task? */
34a54d617785e5 fs/cifs/cifssmb.c       Pavel Shilovsky 2014-07-10  1308  		task_io_account_read(rdata->got_bytes);
34a54d617785e5 fs/cifs/cifssmb.c       Pavel Shilovsky 2014-07-10  1309  		cifs_stats_bytes_read(tcon, rdata->got_bytes);
e28bc5b1fdbd6e fs/cifs/cifssmb.c       Jeff Layton     2011-10-19  1310  		break;
e28bc5b1fdbd6e fs/cifs/cifssmb.c       Jeff Layton     2011-10-19  1311  	case MID_REQUEST_SUBMITTED:
e28bc5b1fdbd6e fs/cifs/cifssmb.c       Jeff Layton     2011-10-19  1312  	case MID_RETRY_NEEDED:
e28bc5b1fdbd6e fs/cifs/cifssmb.c       Jeff Layton     2011-10-19  1313  		rdata->result = -EAGAIN;
d913ed17f0a7d7 fs/cifs/cifssmb.c       Pavel Shilovsky 2014-07-10  1314  		if (server->sign && rdata->got_bytes)
d913ed17f0a7d7 fs/cifs/cifssmb.c       Pavel Shilovsky 2014-07-10  1315  			/* reset bytes number since we can not check a sign */
d913ed17f0a7d7 fs/cifs/cifssmb.c       Pavel Shilovsky 2014-07-10  1316  			rdata->got_bytes = 0;
d913ed17f0a7d7 fs/cifs/cifssmb.c       Pavel Shilovsky 2014-07-10  1317  		/* FIXME: should this be counted toward the initiating task? */
d913ed17f0a7d7 fs/cifs/cifssmb.c       Pavel Shilovsky 2014-07-10  1318  		task_io_account_read(rdata->got_bytes);
d913ed17f0a7d7 fs/cifs/cifssmb.c       Pavel Shilovsky 2014-07-10  1319  		cifs_stats_bytes_read(tcon, rdata->got_bytes);
e28bc5b1fdbd6e fs/cifs/cifssmb.c       Jeff Layton     2011-10-19  1320  		break;
e28bc5b1fdbd6e fs/cifs/cifssmb.c       Jeff Layton     2011-10-19  1321  	default:
e28bc5b1fdbd6e fs/cifs/cifssmb.c       Jeff Layton     2011-10-19  1322  		rdata->result = -EIO;
e28bc5b1fdbd6e fs/cifs/cifssmb.c       Jeff Layton     2011-10-19  1323  	}
e28bc5b1fdbd6e fs/cifs/cifssmb.c       Jeff Layton     2011-10-19  1324  
a68c74865f517e fs/smb/client/cifssmb.c David Howells   2024-09-03  1325  	if (rdata->result == -ENODATA) {
a68c74865f517e fs/smb/client/cifssmb.c David Howells   2024-09-03  1326  		__set_bit(NETFS_SREQ_HIT_EOF, &rdata->subreq.flags);
a68c74865f517e fs/smb/client/cifssmb.c David Howells   2024-09-03  1327  		rdata->result = 0;
a68c74865f517e fs/smb/client/cifssmb.c David Howells   2024-09-03  1328  	} else {
a68c74865f517e fs/smb/client/cifssmb.c David Howells   2024-09-03 @1329  		if (rdata->got_bytes < rdata->actual_len &&
a68c74865f517e fs/smb/client/cifssmb.c David Howells   2024-09-03  1330  		    rdata->subreq.start + rdata->subreq.transferred + rdata->got_bytes ==
a68c74865f517e fs/smb/client/cifssmb.c David Howells   2024-09-03  1331  		    ictx->remote_i_size) {
a68c74865f517e fs/smb/client/cifssmb.c David Howells   2024-09-03  1332  			__set_bit(NETFS_SREQ_HIT_EOF, &rdata->subreq.flags);
a68c74865f517e fs/smb/client/cifssmb.c David Howells   2024-09-03  1333  			rdata->result = 0;
a68c74865f517e fs/smb/client/cifssmb.c David Howells   2024-09-03  1334  		}
a68c74865f517e fs/smb/client/cifssmb.c David Howells   2024-09-03  1335  	}
a68c74865f517e fs/smb/client/cifssmb.c David Howells   2024-09-03  1336  
3ee1a1fc398199 fs/smb/client/cifssmb.c David Howells   2023-10-06  1337  	rdata->credits.value = 0;
a68c74865f517e fs/smb/client/cifssmb.c David Howells   2024-09-03  1338  	INIT_WORK(&rdata->subreq.work, cifs_readv_worker);
a68c74865f517e fs/smb/client/cifssmb.c David Howells   2024-09-03  1339  	queue_work(cifsiod_wq, &rdata->subreq.work);
70f08f914a37a0 fs/cifs/cifssmb.c       Enzo Matsumiya  2022-08-05  1340  	release_mid(mid);
34f4deb7c56c6f fs/cifs/cifssmb.c       Pavel Shilovsky 2019-01-16  1341  	add_credits(server, &credits, 0);
e28bc5b1fdbd6e fs/cifs/cifssmb.c       Jeff Layton     2011-10-19  1342  }
e28bc5b1fdbd6e fs/cifs/cifssmb.c       Jeff Layton     2011-10-19  1343  

:::::: The code at line 1329 was first introduced by commit
:::::: a68c74865f517e26728735aba0ae05055eaff76c cifs: Fix SMB1 readv/writev callback in the same way as SMB2/3

:::::: TO: David Howells <dhowells@xxxxxxxxxx>
:::::: CC: Steve French <stfrench@xxxxxxxxxxxxx>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux