On Wed, Sep 04, 2024 at 03:48:44PM +0800, Huang, Ying wrote: > Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes: > > On Mon, Aug 19, 2024 at 10:34:13AM +0800, Huang Ying wrote: ... > >> Signed-off-by: "Huang, Ying" <ying.huang@xxxxxxxxx> > >> Cc: Dan Williams <dan.j.williams@xxxxxxxxx> > >> Cc: David Hildenbrand <david@xxxxxxxxxx> > >> Cc: Davidlohr Bueso <dave@xxxxxxxxxxxx> > >> Cc: Jonathan Cameron <jonathan.cameron@xxxxxxxxxx> > >> Cc: Dave Jiang <dave.jiang@xxxxxxxxx> > >> Cc: Alison Schofield <alison.schofield@xxxxxxxxx> > >> Cc: Vishal Verma <vishal.l.verma@xxxxxxxxx> > >> Cc: Ira Weiny <ira.weiny@xxxxxxxxx> > >> Cc: Alistair Popple <apopple@xxxxxxxxxx> > >> Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > >> Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > >> Cc: Baoquan He <bhe@xxxxxxxxxx> > > > > You may move Cc list after '---', so it won't unnecessarily pollute the commit > > message. > > Emm... It appears that it's a common practice to include "Cc" in the > commit log. For what benefit? (Note, nowadays we have lore.kernel.org which is under the control of Linux kernel project) Personally I see only downsides of these being inside the commit message. Here is a discussion about this https://lore.kernel.org/linux-doc/20240423132024.2368662-1-andriy.shevchenko@xxxxxxxxxxxxxxx/ ... > >> + ostart = max(res.start, p->start); > >> + oend = min(res.end, p->end); > > > > Isn't a reinvention of resource_intersection()? With that in place you may also > > drop the above resource_overlaps(). > > sizeof(struct resource) == 8 * sizeof(unsigned long) > > Just want to avoid to define another struct resource on stack. Is it a problem? -- With Best Regards, Andy Shevchenko
