Hi, Andy, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes: > On Mon, Sep 02, 2024 at 10:07:52AM +0800, Huang, Ying wrote: >> Dan Williams <dan.j.williams@xxxxxxxxx> writes: >> > Huang, Ying wrote: >> >> Dan Williams <dan.j.williams@xxxxxxxxx> writes: >> >> > Huang Ying wrote: > > [..] > > Looking at how many troubles touching kernel/resource.c may lead to, here is > the question(s): > 1) do we have a test cases in general for this library? > 2) can this change be coupled with an addition/update of the test cases? Yes. This is reasonable. As far as I know, Dan has plan to add some unit tests for region_intersects(). Hi, Dan, Have you started working on the unit tests? If needed, please let me know so I can assist. -- Best Regards, Huang, Ying