Hi Jason, hi Michael,
Le 02/09/2024 à 16:19, Jason A. Donenfeld a écrit :
On Mon, Sep 02, 2024 at 04:16:48PM +0200, Christophe Leroy wrote:
Can do that, but there will still be a problem with chacha selftests if
I don't opt-out the entire function content when it is ppc64. It will
build properly but if someone runs it on a ppc64 it will likely crash
because only the low 32 bits of registers will be saved.
What if you don't wire up the selftests _at all_ until the ppc64 commit?
Then there'll be no risk.
(And I think I would prefer to see the 32-bit code all in the 32-bit
commit; that'd make it more straight forward to review too.)
I'd be fine with that but I'd like feedback from Michael on it: Is there
a risk to only get PPC32 part merged as a first step or will both PPC32
and PPC64 go together anyway ?
I would prefer not to delay PPC32 because someone doesn't feel confident
with PPC64.
Christophe
