On Mon, Aug 13, 2012 at 11:41:44AM -0400, Konrad Rzeszutek Wilk wrote: > On Wed, Aug 08, 2012 at 03:50:46PM -0700, David Miller wrote: > > From: Mel Gorman <mgorman@xxxxxxx> > > Date: Tue, 7 Aug 2012 09:55:55 +0100 > > > > > Commit [c48a11c7: netvm: propagate page->pfmemalloc to skb] is responsible > > > for the following bug triggered by a xen network driver > > ... > > > The problem is that the xenfront driver is passing a NULL page to > > > __skb_fill_page_desc() which was unexpected. This patch checks that > > > there is a page before dereferencing. > > > > > > Reported-and-Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> > > > Signed-off-by: Mel Gorman <mgorman@xxxxxxx> > > > > That call to __skb_fill_page_desc() in xen-netfront.c looks completely bogus. > > It's the only driver passing NULL here. > > It looks to be passing a valid page pointer (at least by looking > at the code) so I am not sure how it got turned in a NULL. > Are we looking at different code bases? I see this and I was assuming it was the source of the bug. __skb_fill_page_desc(skb, 0, NULL, 0, 0); -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>