Re: [RFC PATCH 3/4] mm/page_isolation: remove migratetype from undo_isolate_page_range()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Zi Yan <ziy@xxxxxxxxxx>, linux-mm@xxxxxxxxx
Subject: Re: [RFC PATCH 3/4] mm/page_isolation: remove migratetype from undo_isolate_page_range()
From: David Hildenbrand <david@xxxxxxxxxx>
Date: Mon, 2 Sep 2024 11:00:14 +0200
Cc: Oscar Salvador <osalvador@xxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, Johannes Weiner <hannes@xxxxxxxxxxx>, Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>, "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx>, Mel Gorman <mgorman@xxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20240828202240.2809740-4-ziy@nvidia.com>
Organization: Red Hat
References: <20240828202240.2809740-1-ziy@nvidia.com> <20240828202240.2809740-4-ziy@nvidia.com>
User-agent: Mozilla Thunderbird

On 28.08.24 22:22, Zi Yan wrote:

Since migratetype is no longer overwritten during pageblock isolation,
undoing pageblock isolation no longer needs which migratetype to restore.

Signed-off-by: Zi Yan <ziy@xxxxxxxxxx>
---


Yes, that's the right way of doing it.

Acked-by: David Hildenbrand <david@xxxxxxxxxx>

--
Cheers,

David / dhildenb

Follow-Ups:
- Re: [RFC PATCH 3/4] mm/page_isolation: remove migratetype from undo_isolate_page_range()
  - From: Zi Yan

References:
- [RFC PATCH 0/4] Make MIGRATE_ISOLATE a standalone bit
  - From: Zi Yan
- [RFC PATCH 3/4] mm/page_isolation: remove migratetype from undo_isolate_page_range()
  - From: Zi Yan

Prev by Date: Re: [PATCH 0/2] mm: make copy_to_kernel_nofault() not fault on user addresses
Next by Date: Re: [PATCH] bcachefs: Switch to memalloc_flags_do() for vmalloc allocations
Previous by thread: [RFC PATCH 3/4] mm/page_isolation: remove migratetype from undo_isolate_page_range()
Next by thread: Re: [RFC PATCH 3/4] mm/page_isolation: remove migratetype from undo_isolate_page_range()
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]