Hi Nitin, On Mon, Aug 13, 2012 at 10:36:47PM -0700, Nitin Gupta wrote: > On 08/13/2012 07:35 PM, Greg Kroah-Hartman wrote: > > On Wed, Aug 08, 2012 at 03:12:13PM +0900, Minchan Kim wrote: > >> This patchset promotes zram/zsmalloc from staging. > >> Both are very clean and zram is used by many embedded product > >> for a long time. > >> > >> [1-3] are patches not merged into linux-next yet but needed > >> it as base for [4-5] which promotes zsmalloc. > >> Greg, if you merged [1-3] already, skip them. > > > > I've applied 1-3 and now 4, but that's it, I can't apply the rest > > without getting acks from the -mm maintainers, sorry. Please work with > > them to get those acks, and then I will be glad to apply the rest (after > > you resend them of course...) > > > > On a second thought, I think zsmalloc should stay in drivers/block/zram > since zram is now the only user of zsmalloc since zcache and ramster are > moving to another allocator. Secondly, zsmalloc does not provide > standard slab like interface, so should not be part of mm/. At the best, > it could be moved to lib/ with header in include/linux just like genalloc. I don't care whether it's located in /mm or wherever. But if we move it into out of /mm, I would like to confirm it from akpm. AFAIRC, he had a concern about that because zsmalloc used a few fields of struct page freely so he wanted to locate it in /mm. Andrew, Any thought? >-- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>