On Sat, 31 Aug 2024 15:04:16 +0100 Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote: > On Thu, Aug 29, 2024 at 10:54:52PM +0800, Kefeng Wang wrote: > > Non-LRU movable folio isolation will fail if it can't grab a reference > > in isolate_movable_page(), so folio_get_nontail_page() could be called > > ahead to unify the handling of non-LRU movable/LRU folio isolation a bit, > > this is also prepare to convert isolate_movable_page() to take a folio. > > Since the reference count of the non-LRU movable folio is increased, > > a folio_put() is needed whether the folio is isolated or not. > > There's a reason I stopped where I did when converting this function > to use folios. Usually I would explain, but I think it would do you > good to think about why for a bit. Can we have a code comment explaining this thinking to other readers? > Andrew, please drop these patches. Sure.
