On Mon 13-08-12 21:24:36, Hillf Danton wrote: > On Mon, Aug 13, 2012 at 9:09 PM, Michal Hocko <mhocko@xxxxxxx> wrote: > > On Mon 13-08-12 20:10:41, Hillf Danton wrote: > >> On Sun, Aug 12, 2012 at 5:31 PM, Michal Hocko <mhocko@xxxxxxx> wrote: > >> > From d07b88a70ee1dbcc96502c48cde878931e7deb38 Mon Sep 17 00:00:00 2001 > >> > From: Michal Hocko <mhocko@xxxxxxx> > >> > Date: Fri, 10 Aug 2012 15:03:07 +0200 > >> > Subject: [PATCH] hugetlb: do not use vma_hugecache_offset for > >> > vma_prio_tree_foreach > >> > > >> > 0c176d5 (mm: hugetlb: fix pgoff computation when unmapping page > >> > from vma) fixed pgoff calculation but it has replaced it by > >> > vma_hugecache_offset which is not approapriate for offsets used for > >> > vma_prio_tree_foreach because that one expects index in page units > >> > rather than in huge_page_shift. > >> > >> > >> What if another case of vma_prio_tree_foreach in try_to_unmap_file > >> is correct? > > > > That one is surely correct (linear_page_index converts the page offset). > > But linear_page_index is not used in this patch, why? I will leave it as an excersise for the careful reader... -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>