On 08/30, Jiri Olsa wrote: > > with this change the probe will not get removed in the attached test, > it'll get 2 hits, without this change just 1 hit I don't understand the code in tools/...bpf../ at all, can't comment, > but I'm not sure it's a big problem, because seems like that's not the > intended way the removal should be used anyway, as explained by Oleg [1] It seems that I confused you again ;) No, I think you found a problem. UPROBE_HANDLER_REMOVE can be lost if uc->filter == NULL of if it returns true. See another reply I sent a minute ago. I think the fix is simple, plus we need to cleanup this logic anyway, I'll try to send some code on Monday. Oleg.
