On Wed, Aug 28, 2024 at 3:38 PM Yosry Ahmed <yosryahmed@xxxxxxxxxx> wrote: > > On Wed, Aug 28, 2024 at 2:35 AM Kanchana P Sridhar > <kanchana.p.sridhar@xxxxxxxxx> wrote: > Are you saying that in the "Before" data we end up skipping zswap > completely because of using mTHPs? > > Does it make more sense to turn CONFIG_THP_SWAP in the "Before" data > to force the mTHPs to be split and for the data to be stored in zswap? > This would be a more fair Before/After comparison where the memory > goes to zswap in both cases, but "Before" has to be split because of > zswap's lack of support for mTHP. I assume most setups relying on > zswap will be turning CONFIG_THP_SWAP off today anyway, but maybe not. > Nhat, is this something you can share? I think we're enabling it, but we're a zswap heavy shop + THP allocation is not suuuper reliable until recently with Johannes' latest (and upcoming) work, so I don't have much data to share :)
