Hi Shakeel, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] [also build test ERROR on linus/master v6.11-rc5 next-20240827] [cannot apply to vbabka-slab/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Shakeel-Butt/memcg-add-charging-of-already-allocated-slab-objects/20240827-073150 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20240826232908.4076417-1-shakeel.butt%40linux.dev patch subject: [PATCH v1] memcg: add charging of already allocated slab objects config: openrisc-allnoconfig (https://download.01.org/0day-ci/archive/20240827/202408272111.T6bMZmU9-lkp@xxxxxxxxx/config) compiler: or1k-linux-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240827/202408272111.T6bMZmU9-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202408272111.T6bMZmU9-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): In file included from include/asm-generic/bug.h:5, from arch/openrisc/include/asm/bug.h:5, from include/linux/bug.h:5, from include/linux/mmdebug.h:5, from include/linux/mm.h:6, from mm/slub.c:13: mm/slub.c: In function 'kmem_cache_charge': >> mm/slub.c:4115:44: error: 'struct slabobj_ext' has no member named 'objcg' 4115 | if (unlikely(slab_exts[off].objcg)) | ^ include/linux/compiler.h:77:45: note: in definition of macro 'unlikely' 77 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ vim +4115 mm/slub.c 4085 4086 #define KMALLOC_TYPE (SLAB_KMALLOC | SLAB_CACHE_DMA | \ 4087 SLAB_ACCOUNT | SLAB_RECLAIM_ACCOUNT) 4088 4089 bool kmem_cache_charge(void *objp, gfp_t gfpflags) 4090 { 4091 struct slabobj_ext *slab_exts; 4092 struct kmem_cache *s; 4093 struct folio *folio; 4094 struct slab *slab; 4095 unsigned long off; 4096 4097 if (!memcg_kmem_online()) 4098 return true; 4099 4100 folio = virt_to_folio(objp); 4101 if (unlikely(!folio_test_slab(folio))) 4102 return false; 4103 4104 slab = folio_slab(folio); 4105 s = slab->slab_cache; 4106 4107 /* Ignore KMALLOC_NORMAL cache to avoid circular dependency. */ 4108 if ((s->flags & KMALLOC_TYPE) == SLAB_KMALLOC) 4109 return true; 4110 4111 /* Ignore already charged objects. */ 4112 slab_exts = slab_obj_exts(slab); 4113 if (slab_exts) { 4114 off = obj_to_index(s, slab, objp); > 4115 if (unlikely(slab_exts[off].objcg)) 4116 return true; 4117 } 4118 4119 return memcg_slab_post_charge(s, objp, gfpflags); 4120 } 4121 EXPORT_SYMBOL(kmem_cache_charge); 4122 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
